Time Evolution Framework with primitives.#8681
Conversation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3048002047
💛 - Coveralls |
Cryoris
left a comment
There was a problem hiding this comment.
Some minor comments otherwise LGTM 👍🏻
This is creating new interfaces here based on a copy of the originals right (not moving them perse). The originals, in Should we do trotter_qrte in this same PR since that would span all the code which has been released (code added by VarQTE and PVQD, since it has not yet been released, can be moved). At this point I think we should add a |
|
@dlasecki Did you have any feedback to this comment from above
|
c8170ca to
387ce78
Compare
…into evolution-framework-primitives
Hello, I did not think much about it beforehand but I liked your idea about adding Time to class names. It will be more consistent with the package, more explanatory and a clearer differentiator from old classes. I suppose we can accept slightly longer names due to this change. I went ahead and updated classes according to your idea, including linking them to the algorithms init file which should solve the missing documentation. |
afbdaec to
4795b45
Compare
* Implemented observables_evaluator.py with primitives. * Added evolvers problems and interfaces to time_evolvers package. * Mostly updated trotter_qrte.py to use primitives. * Added observables_evaluator.py that uses primitives. * Added observables_evaluator.py that uses primitives. * Updated trotter_qrte.py to use primitives. * Updated imports * Updated typehints and limited use of opflow. * Updated typehints and limited use of opflow. * Removed files out of scope for this PR. * Added annotations import. * Applied some CR comments. * Added reno. * Accepting Statevector. * Added attributes docs. * Add pending deprecation for evolvers * Renamed classes and linked to algorithms init. * fix docstring * Improved reno. * Code refactoring. * Black fix. * Applied CR comments. * Add deprecation msg to evolvers package Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
* Implemented observables_evaluator.py with primitives. * Added evolvers problems and interfaces to time_evolvers package. * Mostly updated trotter_qrte.py to use primitives. * Added observables_evaluator.py that uses primitives. * Added observables_evaluator.py that uses primitives. * Updated trotter_qrte.py to use primitives. * Updated imports * Updated typehints and limited use of opflow. * Updated typehints and limited use of opflow. * Removed files out of scope for this PR. * Added annotations import. * Applied some CR comments. * Added reno. * Accepting Statevector. * Added attributes docs. * Add pending deprecation for evolvers * Renamed classes and linked to algorithms init. * fix docstring * Improved reno. * Code refactoring. * Black fix. * Applied CR comments. * Add deprecation msg to evolvers package Co-authored-by: Manoel Marques <Manoel.Marques@ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Summary
This PR moves time evolution interfaces and classes to a new location where primitive-enabled time evolution algorithms will reside. It also limits the use of opflow objects.
Closes: TODO
Details and comments