Skip to content

Fix mypy errors (dagcircuit) #8252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 3 commits into from
Nov 19, 2022
Merged

Fix mypy errors (dagcircuit) #8252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d520fa
Fix dagcircuit mypy errors
Randl Jun 28, 2022
ce3e392
Move annotation to function parameter
Randl Nov 15, 2022
1244526
Merge branch 'main' into mypy-1
1ucian0 Nov 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions qiskit/dagcircuit/dagcircuit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import copy
import itertools
import math
from typing import Generator, Any, List

import numpy as np
import rustworkx as rx
Expand Down Expand Up @@ -84,8 +85,8 @@ def __init__(self):
self.cregs = OrderedDict()

# List of Qubit/Clbit wires that the DAG acts on.
self.qubits = []
self.clbits = []
self.qubits: List[Qubit] = []
self.clbits: List[Clbit] = []

self._global_phase = 0
self._calibrations = defaultdict(dict)
Expand Down Expand Up @@ -1051,7 +1052,7 @@ def _key(x):

return iter(rx.lexicographical_topological_sort(self._multi_graph, key=key))

def topological_op_nodes(self, key=None):
def topological_op_nodes(self, key=None) -> Generator[DAGOpNode, Any, Any]:
"""
Yield op nodes in topological order.

Expand Down
5 changes: 3 additions & 2 deletions qiskit/dagcircuit/dagnode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@
"""Objects to represent the information at a node in the DAGCircuit."""

import warnings
from typing import Iterable

from qiskit.circuit import Clbit
from qiskit.circuit import Qubit, Clbit


def _condition_as_indices(operation, bit_indices):
Expand Down Expand Up @@ -110,7 +111,7 @@ class DAGOpNode(DAGNode):

__slots__ = ["op", "qargs", "cargs", "sort_key"]

def __init__(self, op, qargs=(), cargs=()):
def __init__(self, op, qargs: Iterable[Qubit] = (), cargs: Iterable[Clbit] = ()):
"""Create an Instruction node"""
super().__init__()
self.op = op
Expand Down