Fix mypy errors (dagcircuit)#8252
Conversation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
HuangJunye
added
the
Community PR
1ucian0
left a comment
1ucian0
left a comment
There was a problem hiding this comment.
thanks for splitting it! I finally got some time to have a look at this one.
qiskit/dagcircuit/dagnode.py
Outdated
| """Create an Instruction node""" | ||
| super().__init__() | ||
| self.op = op | ||
| self.qargs = tuple(qargs) | ||
| self.cargs = tuple(cargs) | ||
| self.qargs: Optional[Tuple[Qubit, ...]] = tuple(qargs) | ||
| self.cargs: Optional[Tuple[Clbit, ...]] = tuple(cargs) |
There was a problem hiding this comment.
not an expert in type annotation. Would it be better to add them into the method declaration?
There was a problem hiding this comment.
yes, you're right; I've changed it
|
@1ucian0 can you approve, please? :) |
Pull Request Test Coverage Report for Build 3504894567
💛 - Coveralls |
1ucian0
left a comment
1ucian0
left a comment
There was a problem hiding this comment.
Thanks for your patience and your work!
1ucian0
added
automerge
Changelog: None
* Fix dagcircuit mypy errors * Move annotation to function parameter Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
5 participants
Summary
Following discussion, I'm splitting #8187 by module.
Details and comments
This fixes the only mypy errors in dagcircuit as for now.