-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add missing delay instruction to fake backends #8003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1b08e28
Add missing delay instruction to fake backends
mtreinish 2d8e130
Merge branch 'main' into add-target-v2-fake-backend
mtreinish 9459bd7
Add qubits to Delay target entry
mtreinish ece4997
Add release note
mtreinish e7e4d51
Update releasenotes/notes/delay-fake-backends-3f68c074e85d531f.yaml
mtreinish 5785a57
Merge branch 'main' into add-target-v2-fake-backend
mtreinish 7fb901f
Merge branch 'main' into add-target-v2-fake-backend
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
releasenotes/notes/delay-fake-backends-3f68c074e85d531f.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| fixes: | ||
| - | | ||
| The :class:`~.BackendV2` based fake backends in | ||
| the :mod:`qiskit.providers.fake_provider` module, such as | ||
| ``FakeMontrealV2``, previously were missing the :class:`~qiskit.circuit.Delay` operation | ||
| support from their :attr:`~.BackendV2.target` attribute. This prevented | ||
| compiling some :class:`~.QuantumCircuit` objects that contained | ||
| :class:`~qiskit.circuit.Delay` instructions to these backends. This has been corrected | ||
| by adding the :class:`~qiskit.circuit.Delay` to the :class:`~.Target` object for each | ||
| fake backend to ensure that the compiler knows that :class:`~qiskit.circuit.Delay` is | ||
| a valid operation on the fake backends. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.