Add missing delay instruction to fake backends#8003
Merged
Conversation
This commit adds the delay instruction to the target for fake backends based on BackendV2. With BackendV2 and the Target delay isn't assumed to be present on every backend and it has to be explictly listed. This commit fixes this so that the compiler is aware that delay is a valid operation (without any additional constraints) on the BackendV2 based fake backends.
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
HuangJunye
previously approved these changes
May 2, 2022
Collaborator
HuangJunye
left a comment
HuangJunye
left a comment
There was a problem hiding this comment.
Looks good to me too!
If any instructions available in a target are ideal, with no qubits or properties set, the target class assumes the backend is ideal (like in the case of an ideal simulator where are all instructions are globally defined and have no error or duration). To avoid this we need to define the Delay instruction on all qubits explicitly. This commit makes this change to ensure the target for backends still shows the qubits and properties for the other operations. However, in adding an instruction with no properties defined a bug in the plot gate error map function was uncovered where it errored because it assumes all instructions have properties defined, this was fixed at the same time.
Pull Request Test Coverage Report for Build 2266493094
💛 - Coveralls |
mtreinish
commented
May 2, 2022
jakelishman
previously approved these changes
May 3, 2022
Member
jakelishman
left a comment
jakelishman
left a comment
There was a problem hiding this comment.
Is this a bug in 0.20 that needs a release note, or are we good without it?
Member
Author
|
It is arguably a bug in 0.20.0, I was on the fence on whether to backport it or not. I'll add a release note to document it though, that was an oversight. |
jakelishman
previously approved these changes
May 3, 2022
mtreinish
added
the
Changelog: Fixed
mtreinish
commented
May 3, 2022
jakelishman
approved these changes
May 3, 2022
Member
jakelishman
left a comment
jakelishman
left a comment
There was a problem hiding this comment.
Oh yeah, I always forget that pulse defines a bunch of objects with the same names as things in circuit.
ElePT
pushed a commit
to ElePT/qiskit-ibm-provider
that referenced
this pull request
Oct 9, 2023
* Add missing delay instruction to fake backends This commit adds the delay instruction to the target for fake backends based on BackendV2. With BackendV2 and the Target delay isn't assumed to be present on every backend and it has to be explictly listed. This commit fixes this so that the compiler is aware that delay is a valid operation (without any additional constraints) on the BackendV2 based fake backends. * Add qubits to Delay target entry If any instructions available in a target are ideal, with no qubits or properties set, the target class assumes the backend is ideal (like in the case of an ideal simulator where are all instructions are globally defined and have no error or duration). To avoid this we need to define the Delay instruction on all qubits explicitly. This commit makes this change to ensure the target for backends still shows the qubits and properties for the other operations. However, in adding an instruction with no properties defined a bug in the plot gate error map function was uncovered where it errored because it assumes all instructions have properties defined, this was fixed at the same time. * Add release note * Update releasenotes/notes/delay-fake-backends-3f68c074e85d531f.yaml Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds the delay instruction to the target for fake backends
based on BackendV2. With BackendV2 and the Target delay isn't assumed to
be present on every backend and it has to be explictly listed. This
commit fixes this so that the compiler is aware that delay is a valid
operation (without any additional constraints) on the BackendV2 based
fake backends.
Details and comments