Skip to content

Add copy method to Options #7353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 6 commits into from
Dec 6, 2021
Merged

Add copy method to Options #7353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85ebb45
Add copy method to Options
chriseclectic Dec 3, 2021
105a253
black
chriseclectic Dec 3, 2021
708752e
Convert Options.copy() to __copy__
jakelishman Dec 6, 2021
7dcf447
Merge remote-tracking branch 'ibm/main' into options-copy
jakelishman Dec 6, 2021
2137ae3
Update the test
jakelishman Dec 6, 2021
9c2d85c
Remove stale release note
mtreinish Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions qiskit/providers/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,15 @@ def __setstate__(self, state):
super().__setattr__("_fields", _fields)
super().__setattr__("validator", validator)

def __copy__(self):
"""Return a copy of the Options.

The returned option and validator values are shallow copies of the originals.
"""
out = self.__new__(type(self))
out.__setstate__((self._fields.copy(), self.validator.copy()))
return out

def __init__(self, **kwargs):
super().__setattr__("_fields", kwargs)
super().__setattr__("validator", {})
Expand Down
11 changes: 11 additions & 0 deletions test/python/providers/test_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,17 @@ def test_hasattr(self):
self.assertTrue(hasattr(options, "shots"))
self.assertFalse(hasattr(options, "method"))

def test_copy(self):
options = Options(opt1=1, opt2=2)
cpy = copy.copy(options)
cpy.update_options(opt1=10, opt3=20)
self.assertEqual(options.opt1, 1)
self.assertEqual(options.opt2, 2)
self.assertNotIn("opt3", options)
self.assertEqual(cpy.opt1, 10)
self.assertEqual(cpy.opt2, 2)
self.assertEqual(cpy.opt3, 20)


class TestOptionsSimpleNamespaceBackwardCompatibility(QiskitTestCase):
"""Tests that SimpleNamespace-like functionality that qiskit-experiments relies on for Options
Expand Down