Add copy method to Options#7353
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 1544592361
💛 - Coveralls |
Member
|
Did you consider defining |
Member
Author
|
@levbishop Yes, but @jakelishman was strongly against adding that method and said to add a |
Member
|
I read the spec again, and I think I was wrong the first time. I think for what we are, we should implement this method as |
mtreinish
reviewed
Dec 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds copy method to the
Optionclass.Details and comments
The option refactor changes the behaviour of
copy.copy(opts)compared to the original class so that changing option values of the copy also change the original.This adds a
copymethod for returning a shallow copy of option values where changes of the copy do not change the values of the original.This copy functionality is used in qiskit-experiments.