Remove unnecessary parameter table from pulse program#6172
Closed
nkanazawa1989 wants to merge 2 commits into
Closed
Remove unnecessary parameter table from pulse program#6172nkanazawa1989 wants to merge 2 commits into
nkanazawa1989 wants to merge 2 commits into
Conversation
added 2 commits
April 7, 2021 13:31
Member
|
Per the deprecation policy: https://qiskit.org/documentation/contributing_to_qiskit.html#deprecation-policy this is way too soon to remove. I'm marking this as on hold until we have given users a chance to adapt based on the deprecation. |
Contributor
Author
|
replaced with #7267 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #5854 parameter table is deprecated and
ParameterManageris introduced. This PR removes unnecessary parameter tables and.parameters,.assign_parametersmethods from pulse instructions and channels.Details and comments
Simple benchmark
This PR:
CPU times: user 35.8 s, sys: 1.1 s, total: 36.9 s
Wall time: 36.9 s
master:
CPU times: user 46.2 s, sys: 1.36 s, total: 47.6 s
Wall time: 47.6 s
This improvement is simply thanks to the removal of parameter table. All instructions and channels had been initializing the table in the constructor, but this is just an overhead to create new instance. We just added deprecation warning in 0.17, perhaps this PR should be on hold. However, considering the performance improvement, it could be better to remove them soon.