Remove deprecated code from pulse module#7267
Merged
mergify[bot] merged 14 commits intoNov 22, 2021
Merged
Conversation
nkanazawa1989
requested review from
a team,
DanPuzzuoli,
eggerdj,
lcapelluto and
taalexander
as code owners
nkanazawa1989
added
Changelog: Removed
added 2 commits
November 15, 2021 21:16
Pull Request Test Coverage Report for Build 1484319281
💛 - Coveralls |
mtreinish
reviewed
Nov 15, 2021
Member
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
It looks like you need to update the tutorials to stop using deprecated functionality before this will pass CI
This was referenced Nov 15, 2021
Contributor
Author
|
Thanks @mtreinish I updated the corresponding tutorial. Hope this PR will pass CI. |
added 2 commits
November 18, 2021 01:58
…nup-deprecated # Conflicts: # test/python/pulse/test_parameters.py
mtreinish
pushed a commit
to Qiskit/qiskit-tutorials
that referenced
this pull request
Nov 18, 2021
) This is a follow-up to #1253 and is updating the usage of the pulse drawer to avoid deprecated functionality. This is a blocker of Qiskit/qiskit#7267 which is finishing those deprecations and trying to remove the deprecated usage patterns.
mtreinish
reviewed
Nov 19, 2021
Member
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
Overall I think this looks good, just one question inline about the timeline otherwise everything looks good
Comment on lines
1131
to
1182
Member
There was a problem hiding this comment.
Weren't these just deprecated in 0.18.0? I know that was > 3 months ago now so we've passed the minimum 3 month deprecation period but did you want to give people > 1 release to adapt?
Contributor
Author
There was a problem hiding this comment.
I readd these contexts. Thanks for careful investigation. Because these context don't affect data representation of schedules so keeping them for extra release cycles should be fine.
Member
There was a problem hiding this comment.
The deprecation release note shows up in 0.18.0: https://qiskit.org/documentation/release_notes.html#release-notes-0-18-0-deprecation-notes
nkanazawa1989
force-pushed
the
pulse-cleanup-deprecated
branch
from
bec28b0 to
e383bdb
Compare
mtreinish
approved these changes
Nov 22, 2021
Eric-Arellano
pushed a commit
to Eric-Arellano/qiskit-terra
that referenced
this pull request
Aug 25, 2023
…skit/qiskit-tutorials#1254) This is a follow-up to Qiskit/qiskit-tutorials#1253 and is updating the usage of the pulse drawer to avoid deprecated functionality. This is a blocker of Qiskit#7267 which is finishing those deprecations and trying to remove the deprecated usage patterns.
Eric-Arellano
pushed a commit
to Eric-Arellano/qiskit-terra
that referenced
this pull request
Sep 8, 2023
…skit/qiskit-tutorials#1254) This is a follow-up to Qiskit/qiskit-tutorials#1253 and is updating the usage of the pulse drawer to avoid deprecated functionality. This is a blocker of Qiskit#7267 which is finishing those deprecations and trying to remove the deprecated usage patterns.
Eric-Arellano
pushed a commit
to Qiskit/documentation
that referenced
this pull request
Oct 6, 2023
…skit/qiskit-tutorials#1254) This is a follow-up to Qiskit/qiskit-tutorials#1253 and is updating the usage of the pulse drawer to avoid deprecated functionality. This is a blocker of Qiskit/qiskit#7267 which is finishing those deprecations and trying to remove the deprecated usage patterns.
Eric-Arellano
pushed a commit
to Qiskit/documentation
that referenced
this pull request
Oct 9, 2023
…skit/qiskit-tutorials#1254) This is a follow-up to Qiskit/qiskit-tutorials#1253 and is updating the usage of the pulse drawer to avoid deprecated functionality. This is a blocker of Qiskit/qiskit#7267 which is finishing those deprecations and trying to remove the deprecated usage patterns.
Eric-Arellano
pushed a commit
to Qiskit/documentation
that referenced
this pull request
Oct 9, 2023
…skit/qiskit-tutorials#1254) This is a follow-up to Qiskit/qiskit-tutorials#1253 and is updating the usage of the pulse drawer to avoid deprecated functionality. This is a blocker of Qiskit/qiskit#7267 which is finishing those deprecations and trying to remove the deprecated usage patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes deprecated code from the pulse module. These codes have been deprecated for more than 3 months and should be removed for sake of code maintainability.
Details and comments
Corresponding unittests are removed or integrated into the test of alternative logic if any.
This code is partly overlapping with #7265.