Remove DagNode.__hash__()#5979
Merged
Merged
Conversation
kdk
approved these changes
Mar 5, 2021
Member
Well at least for #5952 this won't come up, the retworkx I could definitely see this being a big part of the impact of #5685 though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defining a
__hash__without also defining__eq__goes against the python data model.It looks like in the past there was a custom
__eq__but that was removed in #2006 at which time__hash__should have been removed also.Its also not necessary in this case as a hash based on the object
idis what you get by default.Its also a performance issue: microbenchmarking reveals that set and dict operations are around 10x slower with custom hash compared to default. I didn't check but I wonder how much this was at issue in #5952 and #5685.