Node equality should be based on the internal id#2006
Merged
Conversation
1ucian0
requested review from
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
mtreinish,
nonhermitian and
taalexander
as code owners
…perations.test_dag_ops_on_wire
kdk
previously approved these changes
Mar 25, 2019
kdk
approved these changes
Mar 25, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* back to _match_dag_nodes * simpler * barrier comparison * test * _match_dag_nodes from DAGCircuit to DAGNode * _match_dag_nodes -> semantic_eq * semantic_eq less dependant on networkx * TestCommutationAnalysis compare node names instead of ids * back to compare node ids * compare names instead of ides in test.python.test_dagcircuit.TestDagOperations.test_dag_ops_on_wire * compare ids * compare ids * test.python.transpiler.test_commutation_analysis maxdiff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1994
The function depth checks equality between nodes which is not strict enough. The relaxed version of equality should be in
_match_dag_nodesto check isomorphism.