fix circuit_drawer for linux/mac#554
Merged
Merged
Conversation
diego-plan9
approved these changes
Jun 11, 2018
Member
diego-plan9
left a comment
diego-plan9
left a comment
There was a problem hiding this comment.
Good catch, thanks @ajavadia !
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #543 fixed an issue with filenames on Windows by adding absolute paths. But it broke circuit_drawer functionality on Mac/Linux. This PR fixes that. The absolute paths are still preserved.
Details and comments
The underlying issue was that when doing conversion from
pdftopng, the output file location was not explicitly set. This is now explicit, avoiding inconsistencies between platforms.