fix issue with filename location on windows#543
Merged
Conversation
eendebakpt
requested review from
ajavadia,
atilag,
diego-plan9 and
ewinston
as code owners
Member
|
Thanks @eendebakpt - can you take care of a small linting issue? This seems it will fix #477 |
Contributor
Author
|
@diego-plan9 Did an autopep8 on the modified file, that should fix the linting issue. |
Member
|
Thanks, @eendebakpt ! Actually seems the autopep8 was more thorough than ideal, and picked up a number of style checks that are recommended but not enforced by PEP8 - |
diego-plan9
approved these changes
Jun 7, 2018
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* fix issue with filename location on windows * autopep8 * Revert autopep8 due to E225
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filename of the generated
.pngfile is specified only relative and not found under windows.