Remove "coding: utf-8" (PEP 3120) and add the verify_header checker#5096
Merged
Conversation
1ucian0
requested review from
a team,
maddy-tod and
nonhermitian
as code owners
mtreinish
reviewed
Sep 21, 2020
Member
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
Personally I don't think this is such a big deal, but I agree if we're going to standardize on not having an encoding string in the file then machine enforcing that makes sense. Just one comment about using a regex inline. Otherwise looks fine to me.
| sys.stderr.write("%s failed header check because:\n\n" % i[0]) | ||
| sys.stderr.write("%s\n\n" % i[2]) | ||
| for failed_file in failed_files: | ||
| sys.stderr.write("%s failed header check because:\n" % failed_file[0]) |
Member
There was a problem hiding this comment.
You didn't like the blank line?
Member
Author
There was a problem hiding this comment.
I do not.. specially when you have more than 5 of them :)
mtreinish
reviewed
Sep 21, 2020
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
approved these changes
Sep 21, 2020
Member
Author
I feel the same way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some sort of follow up to #4914 . I extended
tools/verify_headers.pyso the header does not added anymore accidentally.