Skip to content

Remove coding: utf-8 per PEP 3120#4914

Merged
mtreinish merged 1 commit into
Qiskit:masterfrom
levbishop:pep-3120
Aug 12, 2020
Merged

Remove coding: utf-8 per PEP 3120#4914
mtreinish merged 1 commit into
Qiskit:masterfrom
levbishop:pep-3120

Conversation

@levbishop
Copy link
Copy Markdown
Member

@levbishop levbishop commented Aug 12, 2020

utf-8 has been the default since PEP 3120.
https://www.python.org/dev/peps/pep-3120/

Non trivial edits are to Makefile and verify_headers.py

Copy link
Copy Markdown
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always assumed that line was for emacs users since I thought this was the variable format used by emacs: https://www.gnu.org/savannah-checkouts/gnu/emacs/manual/html_node/emacs/Specifying-File-Variables.html#Specifying-File-Variables these lines never did anything for me in vim :P. That being said this LGTM besides the pep this has come up on windows before for release notes and documentation (mostly around the text drawer) so we're explicitly utf8 for all text files in the repo (it might be worth calling that out in the CONTRIBUTING.md)

@mtreinish mtreinish merged commit 779fa14 into Qiskit:master Aug 12, 2020
@jlapeyre
Copy link
Copy Markdown
Contributor

Apparently (https://docs.python.org/3/howto/unicode.html) the syntax for specifying encoding in python was borrowed from emacs. But, as noted in the link, if the encoding is omitted, then utf-8 is assumed.

@levbishop levbishop deleted the pep-3120 branch February 9, 2021 18:23
ElePT pushed a commit to ElePT/qiskit-ibm-provider that referenced this pull request Oct 9, 2023
utf-8 has been the default since PEP 3120.
https://www.python.org/dev/peps/pep-3120/

Non trivial edits are to Makefile and verify_headers.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants