Skip to content

Pulse gates assembly#4901

Closed
lcapelluto wants to merge 21 commits into
Qiskit:masterfrom
lcapelluto:pulse-gates-assembly
Closed

Pulse gates assembly#4901
lcapelluto wants to merge 21 commits into
Qiskit:masterfrom
lcapelluto:pulse-gates-assembly

Conversation

@lcapelluto
Copy link
Copy Markdown
Contributor

@lcapelluto lcapelluto commented Aug 10, 2020

Don't hit update branch on this PR

Summary

blocked on #4859 and #4761

Add piece for assembling front end to the defined qobj schema

Details and comments

TODO

  • handle parametric pulses
  • tests

@lcapelluto lcapelluto force-pushed the pulse-gates-assembly branch 5 times, most recently from 88409f5 to ee8a826 Compare August 11, 2020 20:09
lcapelluto and others added 15 commits August 12, 2020 14:18
…, which needed to be fixed in both the schema and the py files
…g other metadata in the future. Make a qobj.common file to allow qobj.qasm to use features of qobj.pulse
In Qiskit#4728 how we handle the difference between the object units and the
serialization format. However the snapshot update didn't actually save
the correct values in the json and this is causing issues for tutorials
that rely on this. This commit updates the backend snapshots for
backends by rerunning the update script to correct this issue.
@lcapelluto lcapelluto force-pushed the pulse-gates-assembly branch from ee8a826 to e370bf6 Compare August 12, 2020 18:51
SooluThomas and others added 6 commits August 12, 2020 15:18
…ature: pulse library may appear at the top level qasm job config, and each experiment config may have a list of gate calibrations.

Break out assembling pulse gates into its own private function

Add support for parametric pulses
@lcapelluto lcapelluto force-pushed the pulse-gates-assembly branch from e370bf6 to 7b8db8b Compare August 12, 2020 19:18
@lcapelluto lcapelluto marked this pull request as ready for review August 12, 2020 19:18
@lcapelluto lcapelluto requested a review from a team as a code owner August 12, 2020 19:18
@lcapelluto lcapelluto added the on hold Can not fix yet label Aug 12, 2020
@lcapelluto lcapelluto marked this pull request as draft August 12, 2020 19:29
@lcapelluto
Copy link
Copy Markdown
Contributor Author

Ofc there is some weird stuff going on trying to keep this on top of two other PRs

@lcapelluto
Copy link
Copy Markdown
Contributor Author

Replacing with #4969

@lcapelluto lcapelluto closed this Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on hold Can not fix yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants