One reference to get_sample_pulse is raising deprecation warnings fro…#4903
Merged
mergify[bot] merged 1 commit intoAug 10, 2020
Conversation
taalexander
approved these changes
Aug 10, 2020
lcapelluto
added
the
stable backport potential
lcapelluto
added a commit
to lcapelluto/qiskit-terra
that referenced
this pull request
Aug 12, 2020
mergify Bot
added a commit
that referenced
this pull request
Aug 21, 2020
* Update the qobj schema to support pulse gate calibrations. * Fixup qobj classes: add docstrings, call out to super * Move pulse library to top level. Fill in more details in qasm_qobj.py * Fix mistake in schema: the pulse_library definition already contains the 'array' requirement * Move pulse library to top level in qasm_qobj.py as well * Add GateCalibration to qobj/__init__.py * Fixup some implementation errors: gates contains a list of dict items, which needed to be fixed in both the schema and the py files * Put gate calibrations into calibrations.gates to leave room for adding other metadata in the future. Make a qobj.common file to allow qobj.qasm to use features of qobj.pulse * Add an example json * Schema version should be referenced not hardcoded a second time * Pretty print example file * Check if calibrations is present when doing to from dict * Fixup qobj test * Update the qobj schema to support pulse gate calibrations. * Fixup qobj classes: add docstrings, call out to super * Move pulse library to top level. Fill in more details in qasm_qobj.py * Fix mistake in schema: the pulse_library definition already contains the 'array' requirement * Move pulse library to top level in qasm_qobj.py as well * Add GateCalibration to qobj/__init__.py * Fixup some implementation errors: gates contains a list of dict items, which needed to be fixed in both the schema and the py files * Put gate calibrations into calibrations.gates to leave room for adding other metadata in the future. Make a qobj.common file to allow qobj.qasm to use features of qobj.pulse * Add an example json * Schema version should be referenced not hardcoded a second time * Pretty print example file * Update backend snapshots with new conf or defs (#4897) In #4728 how we handle the difference between the object units and the serialization format. However the snapshot update didn't actually save the correct values in the json and this is causing issues for tutorials that rely on this. This commit updates the backend snapshots for backends by rerunning the update script to correct this issue. * One reference to get_sample_pulse is raising deprecation warnings from the assembler (#4903) * Check if calibrations is present when doing to from dict * Fixup qobj test * Add qobj.config.calibrations for common cals * style * Move recent qasm qobj changes to the new qobj.common file * Update schema with qobj level and experiment level calibrations * Add schema test * Apply suggestions from code review Co-authored-by: SooluThomas <soolu.elto@gmail.com> * Fix encoding for validation of new pulse library field in qasm qobj. Add qobj test Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: SooluThomas <soolu.elto@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…m the assembler
Summary
Details and comments