Skip to content

Polish the MPL tester#4604

Merged
mergify[bot] merged 7 commits intoQiskit:masterfrom
1ucian0:mpl_tester
Jun 30, 2020
Merged

Polish the MPL tester#4604
mergify[bot] merged 7 commits intoQiskit:masterfrom
1ucian0:mpl_tester

Conversation

@1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Jun 23, 2020

Kind of #4544 follow up.

  • This PR calls the internal function, so we don't have to worry of changes in the default parameters in the higher level API.
  • I moved all tests from test/python/visualization/test_circuit_matplotlib_drawer.py (including those in fixed issue 4179 by updating matplotlib text scaling #4572)
  • When more than one file is missing or mismatching, I added an option to download a zip with them.

Screen Shot 2020-06-27 at 8 47 33 PM

The result can be seen here: https://mybinder.org/v2/gh/1ucian0/qiskit-terra/mpl_tester?urlpath=apps/test/ipynb/mpl_tester.ipynb

@1ucian0 1ucian0 requested a review from a team as a code owner June 23, 2020 00:32
@1ucian0 1ucian0 marked this pull request as draft June 27, 2020 23:34
@1ucian0 1ucian0 marked this pull request as ready for review June 28, 2020 01:07
@mergify mergify bot merged commit 2909eac into Qiskit:master Jun 30, 2020
faisaldebouni pushed a commit to faisaldebouni/qiskit-terra that referenced this pull request Aug 5, 2020
* polish mpl tester

* when images do not much size

* allow zip download

* lintian

* empty circuit

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants