fixed issue 4179 by updating matplotlib text scaling#4572
Merged
mergify[bot] merged 41 commits intoQiskit:masterfrom Jul 1, 2020
Merged
fixed issue 4179 by updating matplotlib text scaling#4572mergify[bot] merged 41 commits intoQiskit:masterfrom
mergify[bot] merged 41 commits intoQiskit:masterfrom
Conversation
…over a error in text drawer
…b's barrier test case file
Member
|
MPL circuit drawer issues are piling up, since we dont have a good way to track changes on it. I'm putting this PR |
Contributor
Author
|
My bad, meant to just do a regular comment |
Contributor
Author
|
I'm getting the following error when I start the checks. Is this where it is supposed to automatically access the binder or am I supposed to manually go to it and run it? |
Member
|
I moved |
Member
|
I moved |
Merged
1ucian0
approved these changes
Jul 1, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* fixed issue 4391 by updating idle_wires() in dagcircuit and skipping over a error in text drawer * fixed issue 4179 by updating matplotlib scaler * fixed issue 4179 by updating matplotlib drawer and matplotlib testcase * fixed issue 4179 by updating matplotlib drawer and updating matplotlib's barrier test case file * Update dagcircuit.py * Update dagcircuit.py * Update dagcircuit.py * Update dagcircuit.py * Update matplotlib.py * Update text.py * Update text.py * Update matplotlib.py * Update test_circuit_matplotlib_drawer.py * Update test_circuit_matplotlib_drawer.py * Update test_circuit_matplotlib_drawer.py * Update test_circuit_matplotlib_drawer.py * Update test_circuit_matplotlib_drawer.py * fixed issue 4563 by updating matplotlib drawer * Fixes issie 4179 * Update matplotlib.py * Update test_circuit_matplotlib_drawer.py * Delete matplotlib_barriers_ref2.png * Add files via upload * Update matplotlib.py * Update matplotlib.py * Update visualization.py * move test_conditional * plot_barriers * test/ipynb/mpl/references/plot_barriers.png no needed * Update test_circuit_matplotlib_drawer.py * Update test_circuit_matplotlib_drawer.py * duplicated test * test_scale * new refs Co-authored-by: Luciano Bello <luciano.bello@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #4179
Details and comments
Multiplied the outputted font size by the self._scale and removed variable DEFAULT_SCALE altogether(4.3). There was only one instance where the scale parameter was used previously so removing DEFAULT_SCALE was much more efficient than dividing by 4.3 every line that I added in "scale._self * ".