Make test.python.compiler a package#2025
Merged
Merged
Conversation
Add `__init__.py` to `test/python/compiler` in order to turn it into a module.
diego-plan9
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
ewinston,
jaygambetta,
kdk,
mtreinish,
nonhermitian and
taalexander
as code owners
1ucian0
approved these changes
Mar 27, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Add test/python/compiler/__init__.py Add `__init__.py` to `test/python/compiler` in order to turn it into a module. * Linting and style fixes for test_assembler * Temporarily skip test_move_measurements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As sort of a follow-up to #1856, add
test/python/compiler/__init__.py, in order to turn it into a Python package - as otherwise neitherpylintor the test runner in the CIs pick up the files inside that folder.Digging a bit deeper, it seems we have been not running those test since the refactor, and in the process a regression was introduced during #2006, causing
test/python/compiler/test_compiler.py::TestCompiler::test_move_measurementsto fail. This PR temporarily skips the test, in order to allow running the rest of thetest/python/compilertests while investigating further.Details and comments
As a follow-up, we should re-introduce
TestCompiler::test_move_measurements.