Remove already "removed" FakeBackendV2#11997
Merged
Merged
Conversation
Collaborator
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8702630119Details
💛 - Coveralls |
ElePT
changed the title
FakeBackendV2FakeBackendV2
github-merge-queue Bot
pushed a commit
to qiskit-community/qiskit-experiments
that referenced
this pull request
Mar 12, 2024
### Summary In qiskit 0.46, several classes in the `qiskit.providers.fake_provider` module were deprecated, including `qiskit.providers.fake_provider.fake_backend.FakeBackendV2`. However, the removal PR failed to address this particular class, so while this particular `FakeBackendV2` was no longer part of the public API, the import path would still work. This oversight will be addressed in Qiskit/qiskit#11997, but in order to merge this PR we must make sure that all the downstream libraries covered by `qiskit-neko` are up-to-date with the change. This change adds an alternative import path for this class in qiskit-experiments. It follows the pattern from other 1.0 import deprecations. The removal would roll out in the 1.1 release, but it is indicated as a 1.0 removal because that is when it should have technically taken place. ### Details and comments Blocks Qiskit/qiskit#11997.
mergify Bot
pushed a commit
to qiskit-community/qiskit-experiments
that referenced
this pull request
Mar 12, 2024
### Summary In qiskit 0.46, several classes in the `qiskit.providers.fake_provider` module were deprecated, including `qiskit.providers.fake_provider.fake_backend.FakeBackendV2`. However, the removal PR failed to address this particular class, so while this particular `FakeBackendV2` was no longer part of the public API, the import path would still work. This oversight will be addressed in Qiskit/qiskit#11997, but in order to merge this PR we must make sure that all the downstream libraries covered by `qiskit-neko` are up-to-date with the change. This change adds an alternative import path for this class in qiskit-experiments. It follows the pattern from other 1.0 import deprecations. The removal would roll out in the 1.1 release, but it is indicated as a 1.0 removal because that is when it should have technically taken place. ### Details and comments Blocks Qiskit/qiskit#11997. (cherry picked from commit 428c9bc)
Member
|
With qiskit-community/qiskit-experiments#1420 merged, an |
Contributor
Author
We would need qiskit-experiments to do a bugfix/patch release so that neko can pull the fix for its test. I'll ping them about it. |
Contributor
Author
|
The patch release of qiskit-experiments is out! The PR can now be merged. |
mtreinish
approved these changes
Apr 23, 2024
Member
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
I confirmed this is not in the docs anywhere and was just an oversight for removal in 1.0. Heh, but you really like to test the stability policy between this and #12042 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an oversight from #11376 where the
FakeBackendV2base class was removed from the documentation and reported as removed without actually removing the source code for the class (the fact that there were twoFakeBackendV2classes probably didn't help). I'm labeling it aschangelog:Nonebecause this change doesn't affect the public API.Details and comments
On hold until a
qiskit-experimentsrelease that includes qiskit-community/qiskit-experiments@428c9bc. This allow the correspondingqiskit-nekotests to pass.