Remove FakeBackendV2 import deprecated in Qiskit 0.46#1420
Merged
Conversation
wshanks
requested changes
Mar 12, 2024
Comment on lines
50
to
-39
|
|
||
| pass | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
I think this is a change since black 22 which we are still pinned to here. GitHub won't let me suggest the fix in the comment.
wshanks
added
the
backport stable potential
wshanks
changed the title
wshanks
approved these changes
Mar 12, 2024
mergify Bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
### Summary In qiskit 0.46, several classes in the `qiskit.providers.fake_provider` module were deprecated, including `qiskit.providers.fake_provider.fake_backend.FakeBackendV2`. However, the removal PR failed to address this particular class, so while this particular `FakeBackendV2` was no longer part of the public API, the import path would still work. This oversight will be addressed in Qiskit/qiskit#11997, but in order to merge this PR we must make sure that all the downstream libraries covered by `qiskit-neko` are up-to-date with the change. This change adds an alternative import path for this class in qiskit-experiments. It follows the pattern from other 1.0 import deprecations. The removal would roll out in the 1.1 release, but it is indicated as a 1.0 removal because that is when it should have technically taken place. ### Details and comments Blocks Qiskit/qiskit#11997. (cherry picked from commit 428c9bc)
coruscating
pushed a commit
that referenced
this pull request
Mar 12, 2024
#1422) This is an automatic backport of pull request #1420 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In qiskit 0.46, several classes in the
qiskit.providers.fake_providermodule were deprecated, includingqiskit.providers.fake_provider.fake_backend.FakeBackendV2. However, the removal PR failed to address this particular class, so while this particularFakeBackendV2was no longer part of the public API, the import path would still work. This oversight will be addressed in Qiskit/qiskit#11997, but in order to merge this PR we must make sure that all the downstream libraries covered byqiskit-nekoare up-to-date with the change.This change adds an alternative import path for this class in qiskit-experiments. It follows the pattern from other 1.0 import deprecations. The removal would roll out in the 1.1 release, but it is indicated as a 1.0 removal because that is when it should have technically taken place.
Details and comments
Blocks Qiskit/qiskit#11997.