[0.46] upgrade to symengine>=0.11 #11340
Merged
Merged
Conversation
1ucian0
added
the
Changelog: None
Collaborator
|
One or more of the the following people are requested to review this:
|
mtreinish
reviewed
Jan 29, 2024
Member
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
I was looking at the merge conflict on this, the current requirements list on 0.46.0 is:
symengine>=0.9, <0.10; platform_machine == 'x86_64' or platform_machine == 'aarch64' or platform_machine == 'ppc64le' or platform_machine == 'amd64' or platform_machine == 'arm64'
so we're not actually pinning symengine anymore (just excluding 0.10). That being said I think if we wanted to raise the minimum version and fix the workaround, on 0.46 I think that's probably fine. The only change I suggested inline is we still need to remove the workaround for platform support (I left the suggestion inline). On the 0.x release series we didn't require symengine because not every platform has native packages available.
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
reviewed
Jan 30, 2024
mtreinish
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #11315 for 0.46