Skip to content

[1.0] upgrade to symengine>=0.11#11315

Merged
mtreinish merged 9 commits into
Qiskit:mainfrom
1ucian0:symengine/11/1
Jan 23, 2024
Merged

[1.0] upgrade to symengine>=0.11#11315
mtreinish merged 9 commits into
Qiskit:mainfrom
1ucian0:symengine/11/1

Conversation

@1ucian0
Copy link
Copy Markdown
Member

@1ucian0 1ucian0 commented Nov 24, 2023

This PR undoes #8456

Closes #8734

@1ucian0 1ucian0 requested a review from a team as a code owner November 24, 2023 13:44
@qiskit-bot
Copy link
Copy Markdown
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@1ucian0 1ucian0 added this to the 1.0.0 milestone Nov 24, 2023
@1ucian0 1ucian0 added Changelog: None Do not include in the GitHub Release changelog. type: qa Issues and PRs that relate to testing and code quality labels Nov 24, 2023
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 24, 2023

Pull Request Test Coverage Report for Build 7627325587

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 89.516%

Totals Coverage Status
Change from base Build 7627307951: 0.01%
Covered Lines: 59496
Relevant Lines: 66464

💛 - Coveralls

@1ucian0 1ucian0 changed the title Update to symengine>=0.11 upgrade to symengine>=0.11 Nov 24, 2023
Copy link
Copy Markdown
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but can you add a release note documenting the change in the minimum version required for symengine.

@1ucian0
Copy link
Copy Markdown
Member Author

1ucian0 commented Nov 29, 2023

This LGTM, but can you add a release note documenting the change in the minimum version required for symengine.

done!

@1ucian0 1ucian0 changed the title upgrade to symengine>=0.11 [0.1] upgrade to symengine>=0.11 Nov 29, 2023
1ucian0 added a commit to 1ucian0/qiskit-terra that referenced this pull request Nov 29, 2023
@mtreinish mtreinish changed the title [0.1] upgrade to symengine>=0.11 [1.0] upgrade to symengine>=0.11 Dec 1, 2023
@mtreinish mtreinish enabled auto-merge January 23, 2024 14:36
@mtreinish mtreinish added this pull request to the merge queue Jan 23, 2024
Merged via the queue into Qiskit:main with commit 9b5c9c6 Jan 23, 2024
github-merge-queue Bot pushed a commit that referenced this pull request Jan 30, 2024
* port #11315

* Update requirements.txt

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/symengine_1-c907ed541eeb9a02.yaml

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: None Do not include in the GitHub Release changelog. type: qa Issues and PRs that relate to testing and code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants