Remove leftover algorithm/opflow utils#11324
Merged
Merged
Conversation
Collaborator
|
One or more of the the following people are requested to review this:
|
ElePT
added
the
Changelog: Removed
Pull Request Test Coverage Report for Build 7016704061Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
jakelishman
reviewed
Nov 27, 2023
Member
jakelishman
left a comment
jakelishman
left a comment
There was a problem hiding this comment.
I wouldn't profess to know everything that Aqua brought in, but these removals look fine to me and seem to match with #11323.
Comment on lines
+6
to
+18
| * Utils in ``qiskit.utils.arithmetic.py`` | ||
| * Utils in ``qiskit.utils.circuit_utils.py`` | ||
| * Utils in ``qiskit.utils.entangler_map.py`` | ||
| * Utils in ``qiskit.utils.name_unnamed_args.py`` | ||
|
|
||
| These functions were used exclusively in the context of ``qiskit.algorithms`` and | ||
| ``qiskit.opflow``, and were deprecated in Qiskit 0.46, following the deprecations of | ||
| ``qiskit.algorithms`` and ``qiskit.opflow`` in Qiskit 0.45 and Qiskit Terra 0.24 | ||
| respectively. | ||
|
|
||
| The following utilities have also been removed: | ||
|
|
||
| * Utils in ``qiskit.utils.validation.py`` |
Member
There was a problem hiding this comment.
These references are a slightly weird mix of package syntax and filename syntax. I think dropping the .py is what's meant?
jakelishman
approved these changes
Nov 28, 2023
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Dec 3, 2023
With the removal of algorithms and opflow in Qiskit#11324, Qiskit#11111, and Qiskit#11086 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Dec 3, 2023
With the removal of algorithms and opflow in Qiskit#11324, Qiskit#11111, and Qiskit#11086 along with the removal of the BIPMapping transpiler pass in Qiskit#10526 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 3, 2023
With the removal of algorithms and opflow in #11324, #11111, and #11086 along with the removal of the BIPMapping transpiler pass in #10526 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removed the utils deprecated in #11323 .
Details and comments
Instead of adding a separate release note, I decided to edit the original algorithm utils removal one, as these should have been removed together in the first place, and I think it's less confusing to have all utils listed together instead of in two separate entries.