Remove deprecated `opflow` module, `QuantumInstance` and related `utils` by ElePT · Pull Request #11111 · Qiskit/qiskit

ElePT · 2023-10-25T14:51:23Z

Summary

This PR partially addresses #10991 by removing qiskit.opflow, qiskit.utils.quantum_instance.py, and related utils:

qiskit/utils/backend_utils.py
qiskit/utils/measurement_error_mitigation.py
qiskit/utils/mitigation/*
qiskit/utils/run_circuits.py

As well as removing their unit tests, updating the related sphinx references, and removing the API reference entry.

Details and comments

This is PR # 3 of the "Opflow & Algorithms deprecation series", it is on hold until #11086 is merged.

qiskit-bot · 2023-11-09T10:45:45Z

One or more of the the following people are requested to review this:

@Eric-Arellano
@javabster
@Cryoris
@Qiskit/terra-core
@ajavadia
@ikkoham
@levbishop
@mtreinish
@nkanazawa1989
@t-imamichi
@woodsp-ibm

Eric-Arellano

FYI this will break some cross-references for the migration guides. That's fine because the migration guides are ported already to https://docs.quantum-computing.ibm.com/api/migration-guides and we're planning to switch the qisk.it short links this week to them. The IBM docs will update their links to use the 0.44 version of the API docs

woodsp-ibm · 2023-11-09T15:28:42Z

FYI: A PR is updating backend_utils for Aer 0.13 compatibility and is designated to be backported #11172 so I imagine we will want that to merge before the module gets deleted by this PR

coveralls · 2023-11-13T09:17:29Z

Pull Request Test Coverage Report for Build 6946461063

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
71 unchanged lines in 19 files lost coverage.
Overall coverage increased (+0.6%) to 86.966%

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	1	92.42%
qiskit/circuit/library/evolved_operator_ansatz.py	1	83.96%
qiskit/circuit/library/generalized_gates/pauli.py	1	91.18%
qiskit/circuit/parametertable.py	1	87.4%
qiskit/providers/backend.py	1	81.08%
qiskit/providers/basicaer/basicaertools.py	1	91.23%
qiskit/providers/basicaer/qasm_simulator.py	1	85.42%
qiskit/providers/job.py	1	56.9%
qiskit/quantum_info/states/statevector.py	1	89.69%
qiskit/synthesis/evolution/product_formula.py	1	97.56%

Totals
Change from base Build 6944448524:	0.6%
Covered Lines:	60943
Relevant Lines:	70077

💛 - Coveralls

jakelishman

Thanks for doing all this, Elena. It looks like we're on the verge of being ready to go, with overzealous type hints in Aer 0.13 being the only thing that prevents Neko from passing and this from merging.

With Qiskit/qiskit-aer#1996 now merged, we're just waiting on the 0.13.1 patch release of Aer, which at the time of writing, looks just about ready to go: Qiskit/qiskit-aer#1983.

jakelishman · 2023-11-14T22:22:22Z

 SPARSE_PAULI_OP_LIST_ELEM
 -------------------------

-This represents an instance of :class:`.PauliSumOp`.
+This represents an instance of :class:`.SparsePauliOp`.


Co-authored-by: Jake Lishman <jake@binhbar.com>

jakelishman

Thanks for all this! I think this PR is completely ready to merge from our side, we're just waiting for Aer 0.13.1 so Neko can pass.

woodsp-ibm · 2023-11-15T19:37:22Z

From above, since its still not happened

FYI: A PR is updating backend_utils for Aer 0.13 compatibility and is designated to be backported #11172 so I imagine we will want that to merge before the module gets deleted by this PR

ElePT · 2023-11-20T13:36:08Z

From above, since its still not happened

FYI: A PR is updating backend_utils for Aer 0.13 compatibility and is designated to be backported #11172 so I imagine we will want that to merge before the module gets deleted by this PR

Approved and added to the merge queue!

…into remove-opflow

jakelishman · 2023-11-23T09:02:12Z

On hold until Aer 0.13.1 is released.

With the removal of algorithms and opflow in Qiskit#11324, Qiskit#11111, and Qiskit#11086 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.

With the removal of algorithms and opflow in Qiskit#11324, Qiskit#11111, and Qiskit#11086 along with the removal of the BIPMapping transpiler pass in Qiskit#10526 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.

With the removal of algorithms and opflow in #11324, #11111, and #11086 along with the removal of the BIPMapping transpiler pass in #10526 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.

ElePT mentioned this pull request Oct 25, 2023

Remove deprecated qiskit.algorithms module #11086

Merged

ElePT added Changelog: Removed Add a "Removed" entry in the GitHub Release changelog. on hold Can not fix yet mod: opflow labels Oct 25, 2023

ElePT added this to the 1.0.0 milestone Oct 25, 2023

ElePT added 5 commits October 25, 2023 17:40

Remove code, tests, fix tests

962f19e

Remove opflow from docs

01d27fb

Remove opflow references

98782bc

Fix lint, fix docs

e75881f

Fix test

9e2b9e3

ElePT force-pushed the remove-opflow branch from 07529f1 to 9e2b9e3 Compare October 25, 2023 15:49

kdk modified the milestones: 1.0.0, 1.0.0pre1 Oct 30, 2023

t-imamichi mentioned this pull request Nov 7, 2023

Remove opflow classes from primitives #11209

Closed

ElePT added 3 commits November 9, 2023 10:49

Fix conflicts

1c73561

Remove redundant test

ea435c4

Add release note

055da15

ElePT marked this pull request as ready for review November 9, 2023 10:45

ElePT requested review from a team, eggerdj, ikkoham, t-imamichi, woodsp-ibm and wshanks as code owners November 9, 2023 10:45

mtreinish mentioned this pull request Nov 9, 2023

Remove use of opflow and qi in tests Qiskit/qiskit-neko#35

Merged

Eric-Arellano reviewed Nov 9, 2023

View reviewed changes

Remove redirects

0f23edc

ElePT removed the on hold Can not fix yet label Nov 13, 2023

Fix docs

53ce114

ElePT mentioned this pull request Nov 13, 2023

Remove use of opflow in Estimator Qiskit/qiskit-aer#1996

Merged

jakelishman reviewed Nov 14, 2023

View reviewed changes

Apply suggestions from Jake's code review

0858bc1

Co-authored-by: Jake Lishman <jake@binhbar.com>

jakelishman previously approved these changes Nov 15, 2023

View reviewed changes

ElePT mentioned this pull request Nov 15, 2023

Remove deprecated algorithm_globals and validation utils. #11252

Merged

ElePT added 2 commits November 21, 2023 17:01

Fix conflict

b5822ae

Merge branch 'remove-opflow' of https://github.com/ElePT/qiskit-terra …

ddfd916

…into remove-opflow

ElePT dismissed jakelishman’s stale review via ddfd916 November 21, 2023 16:02

1ucian0 approved these changes Nov 23, 2023

View reviewed changes

1ucian0 added this pull request to the merge queue Nov 23, 2023

jakelishman removed this pull request from the merge queue due to a manual request Nov 23, 2023

jakelishman added the on hold Can not fix yet label Nov 23, 2023

ElePT removed the on hold Can not fix yet label Nov 24, 2023

ElePT added this pull request to the merge queue Nov 24, 2023

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 24, 2023

ElePT added this pull request to the merge queue Nov 24, 2023

Merged via the queue into Qiskit:main with commit 20839da Nov 24, 2023

mtreinish mentioned this pull request Dec 3, 2023

Remove unused optional requirements #11364

Merged

This was referenced Dec 19, 2023

Reduce redundant circuit copies and parameter bindings in CircuitSampler #9228

Closed

fixed wrong time value in Trotterized Unitary #8126 #9388

Closed

Cannot get expectation value of list ops or composed ops #7743

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated `opflow` module, `QuantumInstance` and related `utils`#11111

Remove deprecated `opflow` module, `QuantumInstance` and related `utils`#11111
ElePT merged 16 commits into
Qiskit:mainfrom
ElePT:remove-opflow

ElePT commented Oct 25, 2023

Uh oh!

qiskit-bot commented Nov 9, 2023

Uh oh!

Eric-Arellano left a comment

Uh oh!

woodsp-ibm commented Nov 9, 2023 •

edited

Loading

Uh oh!

coveralls commented Nov 13, 2023 •

edited

Loading

Uh oh!

jakelishman left a comment

Uh oh!

Uh oh!

jakelishman Nov 14, 2023

Uh oh!

Uh oh!

Uh oh!

jakelishman left a comment

Uh oh!

woodsp-ibm commented Nov 15, 2023

Uh oh!

ElePT commented Nov 20, 2023

Uh oh!

Uh oh!

jakelishman commented Nov 23, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

ElePT commented Oct 25, 2023

Summary

Details and comments

Uh oh!

qiskit-bot commented Nov 9, 2023

Uh oh!

Eric-Arellano left a comment

Choose a reason for hiding this comment

Uh oh!

woodsp-ibm commented Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Nov 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 6946461063

Warning: This coverage report may be inaccurate.

💛 - Coveralls

Uh oh!

jakelishman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jakelishman Nov 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jakelishman left a comment

Choose a reason for hiding this comment

Uh oh!

woodsp-ibm commented Nov 15, 2023

Uh oh!

ElePT commented Nov 20, 2023

Uh oh!

Uh oh!

jakelishman commented Nov 23, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

woodsp-ibm commented Nov 9, 2023 •

edited

Loading

coveralls commented Nov 13, 2023 •

edited

Loading