Split out matplotlib and qcstyle as separate modules #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
nonhermitian and
taalexander
as code owners
This commit starts the decomposition of the _circuit_visualization module into having separate modules per output backend. The _circuit_visualization module has is quite bulky containing the implementation of 2 different visualization backends. This starts by splitting out matplotlib and QCStyle. The latex backend will be done soon, but it currently in flux with multiple open pull requests. Once development calms on that backend it too will be spit into a separate module. Starts Qiskit#1104
mtreinish
force-pushed
the
split-circuit-backends
branch
from
f5669bf to
d46b84f
Compare
jaygambetta
approved these changes
Oct 16, 2018
This was referenced Oct 23, 2018
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
This commit starts the decomposition of the _circuit_visualization module into having separate modules per output backend. The _circuit_visualization module has is quite bulky containing the implementation of 2 different visualization backends. This starts by splitting out matplotlib and QCStyle. The latex backend will be done soon, but it currently in flux with multiple open pull requests. Once development calms on that backend it too will be spit into a separate module. Starts Qiskit#1104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit starts the decomposition of the _circuit_visualization
module into having separate modules per output backend. The
_circuit_visualization module has is quite bulky containing the
implementation of 2 different visualization backends. This starts by
splitting out matplotlib and QCStyle. The latex backend will be done
soon, but it currently in flux with multiple open pull requests. Once
development calms on that backend it too will be spit into a separate
module.
Details and comments
Starts #1104
We'll also have to update _qcstyle.py here if #1100 merges first.