Skip to content

Conversation

@mtreinish
Copy link
Member

Summary

This commit adds support to the latex circuit drawers (output 'latex'
and 'latex_source') for respecting the plotbarrier style config setting.
However, to maintain backwards compatibility for the latex drawer the
default style has to change from false to true.

Details and comments

Partially addresses #1099

ajavadia
ajavadia previously approved these changes Oct 16, 2018
@ajavadia
Copy link
Member

Thanks. Can you please add the style options that are supported by the generic circuit_drawer to its docstring? Since that's the only public method, currently the user has no way of knowing about style options such as plotbarrier and reversebits.

@mtreinish
Copy link
Member Author

mtreinish commented Oct 16, 2018

@ajavadia yeah I was thinking about that too, especially because of #1104 were I split out QCStyle into it's own module. I'll work on a doc patch for circuit_drawer() about the style options after this merges.

This commit adds support to the latex circuit drawers (output 'latex'
and 'latex_source') for respecting the plotbarrier style config setting.
However, to maintain backwards compatibility for the latex drawer the
default style has to change from false to true.

Partially addresses Qiskit#1099
@mtreinish
Copy link
Member Author

Had to manually rebase because of the merge conflicts.

@mtreinish mtreinish merged commit 02200d2 into Qiskit:master Oct 16, 2018
@mtreinish mtreinish deleted the latex-plotbarriers branch October 16, 2018 16:07
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
)

This commit adds support to the latex circuit drawers (output 'latex'
and 'latex_source') for respecting the plotbarrier style config setting.
However, to maintain backwards compatibility for the latex drawer the
default style has to change from false to true.

Partially addresses Qiskit#1099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants