Use qiskit-ibm-provider api code#871
Merged
kt474 merged 15 commits intoQiskit:mainfrom Jul 7, 2023
Merged
Conversation
Pull Request Test Coverage Report for Build 5489535000
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Overall looks fine. A few comments:
- In
qiskit_ibm_runtime/api/clients/base.py,retries==8and inqiskit-ibm-provider/qiskit_ibm_provider/api/clients/base.pyit is5. Do you want to change it to 8 in provider? - There are quite a few differences between
qiskit_ibm_runtime/api/rest/backend.pyandqiskit-ibm-provider/qiskit_ibm_provider/api/rest/backend.py. Do we need to copy any of these to provider? - Same as (2) for
qiskit_ibm_runtime/api/rest/program_job.pyandqiskit-ibm-provider/api/rest/program_job.py - Same for
qiskit_ibm_runtime/api/rest/root.pyandqiskit-ibm-provider/api/rest/root.py. In particular, the former has areservationsmethod.
merav-aharoni
approved these changes
Jul 4, 2023
Contributor
Author
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removing as much duplication as possible from the api code
api/clients: auth.py, base.py, runtime_ws.py, version.py
api/rest: backend.py, base.py, program_job.py, root.py
Details and comments
Fixes other half of #548