Use qiskit-ibm-provider#859
Merged
kt474 merged 9 commits intoQiskit:mainfrom May 25, 2023
Merged
Conversation
Pull Request Test Coverage Report for Build 5070118368
💛 - Coveralls |
merav-aharoni
approved these changes
May 25, 2023
Contributor
merav-aharoni
left a comment
There was a problem hiding this comment.
Looks good! Will be nice to get rid of all these duplications.
You might as well remove the directories qpy and proxies while you're at it.
Contributor
Author
My understanding is that git will automatically get rid of empty directories, but if not I'll go back and remove them |
This was referenced Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There are many pieces to remove/refactor so I will break it up into smaller PRs
Duplications removed
hgp,ibm_qubit_properties,backend_decoderBackendReservation- this file was never used, I think it was forgotten during the original migrationI will take care of the api related code duplication in a separate PR - in #871
Details and comments
Fixes part of #548