Remove unnecessary buffer allocation at chunk manager initialization (Thrust)#1226
Closed
doichanj wants to merge 5 commits into
Closed
Remove unnecessary buffer allocation at chunk manager initialization (Thrust)#1226doichanj wants to merge 5 commits into
doichanj wants to merge 5 commits into
Conversation
Contributor
Author
|
This fix is merged to PR #1200 , so I would like to close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the fix for issue #1224
Details and comments
Chunk manager allocated buffers for MPI and buffers for checkpoint at the initialization.
However these are unnecessary for most cases. (MPI host buffer is only required for environments without GPUDirectRDMA)
So I removed these allocations and allocate checkpoint buffer when checkpoint is used.