Skip to content

Fixes of multi-chunk simulators#1200

Merged
chriseclectic merged 15 commits into
Qiskit:masterfrom
doichanj:fix-unitary-chunk
Apr 23, 2021
Merged

Fixes of multi-chunk simulators#1200
chriseclectic merged 15 commits into
Qiskit:masterfrom
doichanj:fix-unitary-chunk

Conversation

@doichanj
Copy link
Copy Markdown
Contributor

@doichanj doichanj commented Mar 31, 2021

Summary

This PR fixes bugs of multi-chunk simulators with cache blocking transpiler.

Details and comments

This fix includes:

  • Fix of cache blocking transpiler
  • Fix of initialize/reset operations for statevector/density-matrix simulators
  • Fix of unitary simulator
  • Implementation of set_statevector/set_densitymatrix operators.

@chriseclectic
Copy link
Copy Markdown
Member

@doichanj we removed the UnitaryStateChunk class and method, but should the fixes from this PR to cacheblocking.hpp unitary_state_chunk.hpp and statevector_controller.hpp still be merged?

@doichanj
Copy link
Copy Markdown
Contributor Author

doichanj commented Apr 1, 2021

It is OK to be merged in the next release. I will modify codes applicable for AerSimulator.

@doichanj doichanj changed the title Fix multi-chunk unitary simulator Fixes of multi-chunk simulators Apr 15, 2021
@doichanj
Copy link
Copy Markdown
Contributor Author

I included fix of memory issue #1224 (PR #1226). Some test cases fails in #1226 is fixed in this PR.

@chriseclectic chriseclectic added Changelog: Bugfix Include in the Fixed section of the changelog stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable labels Apr 22, 2021
@chriseclectic chriseclectic merged commit 5460447 into Qiskit:master Apr 23, 2021
chriseclectic added a commit to chriseclectic/qiskit-aer that referenced this pull request Apr 28, 2021
Co-authored-by: Christopher Wood <cjwood@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: Bugfix Include in the Fixed section of the changelog stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants