Fixing cache blocking transpiler for multi-chunk measure, save and kraus operations#1197
Merged
Merged
Conversation
Member
|
This looks to have fixed the test failures with statevector, but after applying these changes in #1194 it looks like there are still some failures for the unitary chunk simulator for save unitary and multi-controlled gates. |
chriseclectic
approved these changes
Mar 30, 2021
Member
chriseclectic
left a comment
chriseclectic
left a comment
There was a problem hiding this comment.
Rather than fix the unitary cache blocking I think it makes sense to just disable it for unitary simulation, since MPI based distributed simulation isn't practical for that method anyway. I will open a separate PR to do this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes cache blocking transpiler bug if the circuit has measure operations in the middle of operation sequence (in case sampling measure can not be applied)
#1193
Details and comments
The measure operations (that can not be merged in sampling) is now applied without restoring qubit map caused by chunk swaps.
Also this PR includes fix for save amplitudes and kraus operator.
Kraus operator is transpiled when target qubits can be fit in chunk otherwise returns error.