Skip to content

Remove entanglement forging#479

Merged
caleb-johnson merged 5 commits into
mainfrom
remove-forging
Feb 9, 2024
Merged

Remove entanglement forging#479
caleb-johnson merged 5 commits into
mainfrom
remove-forging

Conversation

@caleb-johnson
Copy link
Copy Markdown
Collaborator

Nothing in Qiskit-Extensions should rely on the old Qiskit application modules, so we must remove Entanglement Forging from this repository. We can add it to qiskit-community in a standalone repository if we want.

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 9, 2024

Pull Request Test Coverage Report for Build 7849542895

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 93.75%

Totals Coverage Status
Change from base Build 7849519735: 1.3%
Covered Lines: 2430
Relevant Lines: 2592

💛 - Coveralls

@caleb-johnson
Copy link
Copy Markdown
Collaborator Author

caleb-johnson commented Feb 9, 2024

Trying to track down what is causing this pandoc warning, I assume it's one of our notebook deps but not sure.

Other than that, this is ready for review. If we can get this and #480 removed, we can merge #475 and release. We could also clean up some deprecated packages as well before releasing.

@caleb-johnson caleb-johnson merged commit e6de752 into main Feb 9, 2024
@caleb-johnson caleb-johnson deleted the remove-forging branch February 9, 2024 21:11
garrison added a commit that referenced this pull request Feb 10, 2024
garrison added a commit that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants