Qiskit1.0#475
Conversation
This reverts commit 88e2195.
We'll probably also need to bump the version to 0.7 or higher, but let's do that once the code is ready.
Pull Request Test Coverage Report for Build 7875313054Details
💛 - Coveralls |
…toolbox into qiskit1.0
|
@garrison , they have removed |
From qiskit docs: Creating flow controllers with flow_controller_conditions keyword arguments was deprecated. Instead, you must explicitly instantiate a controller and set the controller to passes argument. |
There are a bunch of instances of this migration at https://github.com/Qiskit/qiskit/pull/11448/files (scroll down to the very last change in that diff, for instance). |
mrossinek
left a comment
mrossinek
left a comment
There was a problem hiding this comment.
Just a minor thing but other than that these changes look good to me 👍
| job = PrimitiveJob(self._call, circuits, parameter_values, **run_options) | ||
| job.submit() | ||
| # The public submit method was removed in Qiskit 1.0 | ||
| (job.submit if hasattr(job, "submit") else job._submit)() |
There was a problem hiding this comment.
Seems a bit odd using a private method here. Then again, you do not really have an alternative with the PrimitiveJob interface.
Why exactly is this ExactSampler needed? I would assume that this works the same as Sampler(..., options={"shots": None}), does it not?
There was a problem hiding this comment.
We needed to make ExactSampler because the reference implementation doesn't handle mid-circuit measurements, which is crucial for us.
Ya, this (job.submit if ...)() seemed to be the go-to solution for a couple of other repos as well. The public method didn't carry over from 0.46 to 1.0.
5 participants
Fixes #474
This PR upgrades the code base to be compatible with Qiskit 1.0