Skip to content

Add finalization test #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmidem merged 8 commits into from
Nov 5, 2025
Merged

Add finalization test #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1c71296
Temporary: point zebra-test-ci to zsa-integration-demo-with-state (va…
dmidem Sep 28, 2025
69ca1dc
Return Result from mining helpers and add finalization negative test …
dmidem Sep 29, 2025
e93bf46
Fix clippy issues
dmidem Sep 29, 2025
a3014be
Minor fixes
dmidem Oct 3, 2025
dda95c1
CI: temporarily pin Zebra checkout to 'zsa-integration-demo-with-stat…
dmidem Oct 3, 2025
935ff70
Update FIXME comment in zebra-test-ci.yaml
dmidem Nov 2, 2025
6c18467
Apply PR #42 review feedback: adjust CI workflow and fix a minor issu…
dmidem Nov 3, 2025
73fcd94
ci: free disk space in zebra-test-ci to fix 'No space left on device'
dmidem Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/zebra-test-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Free disk space (safe cleanup for Rust CI)
run: |
# Remove heavy preinstalled SDKs and toolchains
sudo rm -rf /usr/local/lib/android || true
sudo rm -rf /opt/hostedtoolcache || true
df -h

- name: Checkout tx-tool code
uses: actions/checkout@v3
with:
Expand Down
8 changes: 5 additions & 3 deletions src/commands/test_orchard.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ impl Runnable for TestOrchardCmd {

let shielding_tx =
create_shield_coinbase_transaction(miner_addr, coinbase_txid, &mut wallet);
mine(&mut wallet, &mut rpc_client, Vec::from([shielding_tx]));
mine(&mut wallet, &mut rpc_client, Vec::from([shielding_tx]))
.expect("block mined successfully");

let expected_balances = expected_balances_after_mine(&balances, 0);
check_balances(
Expand Down Expand Up @@ -84,7 +85,7 @@ impl Runnable for TestOrchardCmd {

let txs = txi.to_transactions(&mut wallet);

mine(&mut wallet, &mut rpc_client, txs);
mine(&mut wallet, &mut rpc_client, txs).expect("block mined successfully");

check_balances(
AssetBase::native(),
Expand All @@ -104,6 +105,7 @@ impl Runnable for TestOrchardCmd {
fn prepare_test(target_height: u32, wallet: &mut User, rpc_client: &mut ReqwestRpcClient) -> TxId {
sync_from_height(target_height, wallet, rpc_client);
let activate = wallet.last_block_height().is_none();
let (_, coinbase_txid) = mine_empty_blocks(100, rpc_client, activate); // coinbase maturity = 100
let (_, coinbase_txid) =
mine_empty_blocks(100, rpc_client, activate).expect("block mined successfully"); // coinbase maturity = 100
coinbase_txid
}
29 changes: 25 additions & 4 deletions src/commands/test_orchard_zsa.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ use crate::commands::test_balances::{
BurnInfo, TestBalances, TransferInfo, TxiBatch,
};
use crate::components::rpc_client::reqwest::ReqwestRpcClient;
use crate::components::transactions::{create_issue_transaction, mine, sync_from_height};
use crate::components::transactions::{
create_issue_transaction, create_finalization_transaction, mine, sync_from_height,
};
use crate::components::user::User;
use crate::prelude::*;

Expand Down Expand Up @@ -55,7 +57,8 @@ impl Runnable for TestOrchardZSACmd {
let balances = TestBalances::get_asset_balances(asset, num_users, &mut wallet);
print_balances("=== Initial balances ===", asset, &balances);

mine(&mut wallet, &mut rpc_client, Vec::from([issue_tx]));
mine(&mut wallet, &mut rpc_client, Vec::from([issue_tx]))
.expect("block mined successfully");

let balances = TestBalances::get_asset_balances(asset, num_users, &mut wallet);
print_balances("=== Balances after issue ===", asset, &balances);
Expand All @@ -69,7 +72,7 @@ impl Runnable for TestOrchardZSACmd {

let txs = txi.to_transactions(&mut wallet);

mine(&mut wallet, &mut rpc_client, txs);
mine(&mut wallet, &mut rpc_client, txs).expect("block mined successfully");

check_balances(asset, &expected_balances, &mut wallet, num_users);

Expand All @@ -91,12 +94,30 @@ impl Runnable for TestOrchardZSACmd {

let txs = txi.to_transactions(&mut wallet);

mine(&mut wallet, &mut rpc_client, txs);
mine(&mut wallet, &mut rpc_client, txs).expect("block mined successfully");

// burn from issuer(account0) and alice(account1)
check_balances(asset, &expected_balances, &mut wallet, num_users);

print_balances("=== Balances after burning ===", asset, &expected_balances);

// --------------------- Finalization ---------------------

let finalization_tx = create_finalization_transaction(asset_desc_hash, &mut wallet);
mine(&mut wallet, &mut rpc_client, Vec::from([finalization_tx]))
.expect("block mined successfully");

let invalid_issue_tx =
create_issue_transaction(issuer_addr, 2000, asset_desc_hash, true, &mut wallet);
let result = mine(
&mut wallet,
&mut rpc_client,
Vec::from([invalid_issue_tx.0]),
);
assert!(
result.is_err(),
"Issue transaction was unexpectedly accepted after asset finalization"
);
}
}

Expand Down
9 changes: 5 additions & 4 deletions src/commands/test_three_party.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ impl Runnable for TestThreePartyCmd {
let balances = TestBalances::get_asset_balances(asset, num_users, &mut wallet);
print_balances("=== Initial balances ===", asset, &balances);

mine(&mut wallet, &mut rpc_client, Vec::from([issue_tx]));
mine(&mut wallet, &mut rpc_client, Vec::from([issue_tx]))
.expect("block mined successfully");

let balances = TestBalances::get_asset_balances(asset, num_users, &mut wallet);
print_balances("=== Balances after issue ===", asset, &balances);
Expand All @@ -72,7 +73,7 @@ impl Runnable for TestThreePartyCmd {

let txs = txi.to_transactions(&mut wallet);

mine(&mut wallet, &mut rpc_client, txs);
mine(&mut wallet, &mut rpc_client, txs).expect("block mined successfully");

check_balances(asset, &expected_balances, &mut wallet, num_users);

Expand All @@ -96,7 +97,7 @@ impl Runnable for TestThreePartyCmd {

let txs = txi.to_transactions(&mut wallet);

mine(&mut wallet, &mut rpc_client, txs);
mine(&mut wallet, &mut rpc_client, txs).expect("block mined successfully");

check_balances(asset, &expected_balances, &mut wallet, num_users);

Expand All @@ -118,7 +119,7 @@ impl Runnable for TestThreePartyCmd {

let txs = txi.to_transactions(&mut wallet);

mine(&mut wallet, &mut rpc_client, txs);
mine(&mut wallet, &mut rpc_client, txs).expect("block mined successfully");

check_balances(asset, &expected_balances, &mut wallet, num_users);

Expand Down
26 changes: 16 additions & 10 deletions src/components/transactions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ use orchard::note::AssetBase;
use orchard::value::NoteValue;
use orchard::Address;
use rand::rngs::OsRng;
use std::error::Error;
use std::convert::TryFrom;
use std::ops::Add;
use orchard::keys::{IssuanceValidatingKey, SpendAuthorizingKey};
Expand All @@ -27,46 +28,51 @@ use zcash_transparent::bundle::{OutPoint, TxOut};
const COINBASE_VALUE: u64 = 625_000_000;

/// Mine a block with the given transactions and sync the user
pub fn mine(wallet: &mut User, rpc_client: &mut dyn RpcClient, txs: Vec<Transaction>) {
pub fn mine(
wallet: &mut User,
rpc_client: &mut dyn RpcClient,
txs: Vec<Transaction>,
) -> Result<(), Box<dyn Error>> {
Comment thread
PaulLaux marked this conversation as resolved.
let activate = wallet.last_block_height().is_none();
let (_, _) = mine_block(rpc_client, txs, activate);
let (_, _) = mine_block(rpc_client, txs, activate)?;
sync(wallet, rpc_client);
Ok(())
}

/// Mine a block with the given transactions and return the block height and coinbase txid
pub fn mine_block(
rpc_client: &mut dyn RpcClient,
txs: Vec<Transaction>,
activate: bool,
) -> (u32, TxId) {
let block_template = rpc_client.get_block_template().unwrap();
) -> Result<(u32, TxId), Box<dyn Error>> {
Comment thread
PaulLaux marked this conversation as resolved.
let block_template = rpc_client.get_block_template()?;
let block_height = block_template.height;

let block_proposal = template_into_proposal(block_template, txs, activate);
let coinbase_txid = block_proposal.transactions.first().unwrap().txid();

rpc_client.submit_block(block_proposal).unwrap();
rpc_client.submit_block(block_proposal)?;

(block_height, coinbase_txid)
Ok((block_height, coinbase_txid))
}

/// Mine the given number of empty blocks and return the block height and coinbase txid of the first block
pub fn mine_empty_blocks(
num_blocks: u32,
rpc_client: &mut dyn RpcClient,
activate: bool,
) -> (u32, TxId) {
) -> Result<(u32, TxId), Box<dyn Error>> {
if num_blocks == 0 {
panic!("num_blocks must be greater than 0")
}

let (block_height, coinbase_txid) = mine_block(rpc_client, vec![], activate);
let (block_height, coinbase_txid) = mine_block(rpc_client, vec![], activate)?;

for _ in 1..num_blocks {
mine_block(rpc_client, vec![], false);
mine_block(rpc_client, vec![], false)?;
}

(block_height, coinbase_txid)
Ok((block_height, coinbase_txid))
}

/// Create a shielded coinbase transaction
Expand Down