Add finalization test#42
Merged
Merged
Conversation
…(reject issue after finalize)
dmidem
changed the title
dmidem
force-pushed
the
tmp-zebra-test-ci-repoint
branch
from
f91f7d9 to
a3014be
Compare
…e' (bypass env var); add FIXME to revert after PR verification
PaulLaux
reviewed
Nov 3, 2025
Contributor
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Added minor fixes
Also, please updated title and description before merge.
|
|
||
| for _ in 1..num_blocks { | ||
| mine_block(rpc_client, vec![], false); | ||
| mine_block(rpc_client, vec![], false).expect("block mined successfully"); |
Contributor
There was a problem hiding this comment.
why not propagate the error?
Comment on lines
+30
to
+31
| # FIXME: Change to: ref: ${{ vars.ZEBRA_BRANCH_TO_TEST || 'zsa-integration-demo-with-state' }} after this PR is verified. | ||
| ref: zsa-integration-demo-with-state |
Contributor
There was a problem hiding this comment.
revert to the original config once QED-it/zebra#89 (review) is merged
dmidem
changed the title
PaulLaux
changed the title
PaulLaux
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a negative test to ensure ZSA issuance after finalization is rejected.
Also, to enable proper negative testing, it updates the
mine_*helpers to returnResultso tests can assert on expected failures.