Revert asset description hash addition and move burn into action group#27
Closed
vivek-arte wants to merge 3 commits into
Closed
Revert asset description hash addition and move burn into action group#27vivek-arte wants to merge 3 commits into
vivek-arte wants to merge 3 commits into
Conversation
vivek-arte
added a commit
to QED-it/librustzcash
that referenced
this pull request
Apr 21, 2025
…rs (#109) This adjusts the order of reads and writes to place the proof bytes after the timeLimit (nAGExpiryHeight) and burn fields. The updates to the test vectors are from QED-it/zcash-test-vectors#27, and confirm that the tests pass.
Author
|
Closed in favour of #28, which includes both the move of the burn into the action group, and the replacement of the asset description string with the hash of that string. |
vivek-arte
added a commit
to QED-it/librustzcash
that referenced
this pull request
Apr 22, 2025
- This PR serializes burn as part of the action group, as per the changes specified in zcash/zips#991 - This adjusts the order of reads and writes to place the proof bytes after the timeLimit (nAGExpiryHeight) and burn fields. - The updates to the test vectors are from QED-it/zcash-test-vectors#27, and confirm that the tests pass. --------- Co-authored-by: Vivek Arte <46618816+vivek-arte@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR which rolls back the change of the asset description string to asset description hash, and then moves the burn into the Action Group.
I am leaving this as a draft PR, since it is mainly to confirm that QED-it/librustzcash#109 works as expected.
This will require the above-mentioned changes to be added back. It will be done once we have a
librustzcashPR with those changes to confirm the test vectors against.