Serialize burn as part of action group#105
Merged
Merged
Conversation
7df6aa0 to
1403e40
Compare
…rs (#109) This adjusts the order of reads and writes to place the proof bytes after the timeLimit (nAGExpiryHeight) and burn fields. The updates to the test vectors are from QED-it/zcash-test-vectors#27, and confirm that the tests pass.
PaulLaux
approved these changes
Apr 21, 2025
Collaborator
There was a problem hiding this comment.
approved.
first let's merge QED-it/zcash-test-vectors#28.
vivek-arte
approved these changes
Apr 22, 2025
vivek-arte
left a comment
There was a problem hiding this comment.
Merged QED-it/zcash-test-vectors#28, now merging this and updating #110 accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.