Merged
Conversation
Make it possible to generate testnet test vectors for ZIP 320 addresses.
This now takes the generation type or 'all' as the first argument, and then the generator or 'all' as the second argument. File extensions are detemined automatically from the generation type.
Add Orchard ZIP 32 test vectors
Test vectors for ZIP 32 arbitrary key derivation
When using them, I forgot that `bytes(range(32))` doesn't generate an all-zeroes seed of length 32, so I was using the wrong seed with the test vectors and they were failing. We now embed that seed in the test vectors, along with the context string (to make it clear that there is no trailing null byte) and the IKM (which is what clued me into the seed being wrong).
Improve the ZIP 32 arbitrary key derivation test vectors
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
…e of pairs that will be used in the `zip_0032_registered` test vectors. This should not change any of the generated vectors. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Jack Grigg <jack@electriccoin.co> Co-authored-by: Kris Nuttycombe <kris@nutty.land> Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Jack Grigg <jack@electriccoin.co> Co-authored-by: Kris Nuttycombe <kris@nutty.land> Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Add test vectors for ZIP 32 registered key derivation
PaulLaux
reviewed
Apr 28, 2025
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
looks good, added coments for better compatibility with the final orchard files.
PaulLaux
added a commit
to QED-it/orchard
that referenced
this pull request
May 1, 2025
Merge zcash/orchard (commit fcb14de) into zsa1 with following modifications - Update tests comparing orchard digest against a fixed value (the default memo value has been updated) - Import the last version of generated test_vectors files (see QED-it/zcash-test-vectors#26) - Fix clippy errors - Expose (Extracted)NoteCommitment in public API
PaulLaux
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main modifications