Skip to content

Add test vectors for ZIP 32 registered key derivation#105

Merged
str4d merged 6 commits into
zcash:masterfrom
daira:add-registered-test-vectors
Feb 20, 2025
Merged

Add test vectors for ZIP 32 registered key derivation#105
str4d merged 6 commits into
zcash:masterfrom
daira:add-registered-test-vectors

Conversation

@daira
Copy link
Copy Markdown
Contributor

@daira daira commented Feb 17, 2025

No description provided.

Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
@daira daira force-pushed the add-registered-test-vectors branch 4 times, most recently from 6c8191c to 2d637f1 Compare February 17, 2025 21:05
@daira daira marked this pull request as ready for review February 17, 2025 21:23
@daira daira requested review from nuttycom and str4d February 17, 2025 21:27
Comment thread zcash_test_vectors/zip_0032.py Outdated
Comment thread zcash_test_vectors/zip_0032.py Outdated
Comment thread zcash_test_vectors/zip_0032.py Outdated
@daira daira force-pushed the add-registered-test-vectors branch 2 times, most recently from 493bb5d to a03d8ea Compare February 20, 2025 03:56
Comment thread zcash_test_vectors/zip_0032.py Outdated
@daira daira force-pushed the add-registered-test-vectors branch from 417052d to f0e5bdb Compare February 20, 2025 04:53
daira and others added 4 commits February 20, 2025 05:00
…e of

pairs that will be used in the `zip_0032_registered` test vectors. This
should not change any of the generated vectors.

Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
@daira daira force-pushed the add-registered-test-vectors branch from f0e5bdb to cbfe5ed Compare February 20, 2025 05:36
@daira
Copy link
Copy Markdown
Contributor Author

daira commented Feb 20, 2025

Ready for re-review (commit-by-commit suggested).

@daira daira requested a review from str4d February 20, 2025 05:40
Copy link
Copy Markdown
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK cbfe5ed. Thanks for refactoring the commits ❤️

@str4d str4d merged commit ba707b1 into zcash:master Feb 20, 2025
@daira daira deleted the add-registered-test-vectors branch February 20, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants