Changes to TXID generation to account for ZSA additions#22
Merged
vivek-arte merged 36 commits intozsa1from Sep 19, 2024
Merged
Conversation
…sts, and adding NU6 constants to transaction.py
…d moving TransactionV6 to transaction_zsa.py
vivek-arte
force-pushed
the
tx_zsa_changes
branch
from
3aa3096 to
c33d00a
Compare
This was referenced Jun 18, 2024
vivek-arte
added a commit
to QED-it/librustzcash
that referenced
this pull request
Jul 24, 2024
) This PR makes the following changes: - reordering of the component fields in `read_action` and `write_action` in issuance in order to make them spec compliant. - It sets some of the constant values for NU7 in a way that is consistent with the generated test vectors from the Python reference implementation (See QED-it/zcash-test-vectors#22 for the changes to the Python reference implementation). - Some changes are made to function names to reflect the shift from preparing ZSAs for V7 rather than V6. - There are changes to the tests to use the `zcash_unstable` flag in order to cover both ZSA and vanilla Orchard behavior. - The test vectors are also expanded to include both the V5 vectors, and the V7 vectors (behind a `zcash_unstable` flag).
alexeykoren
pushed a commit
to QED-it/librustzcash
that referenced
this pull request
Jul 24, 2024
) This PR makes the following changes: - reordering of the component fields in `read_action` and `write_action` in issuance in order to make them spec compliant. - It sets some of the constant values for NU7 in a way that is consistent with the generated test vectors from the Python reference implementation (See QED-it/zcash-test-vectors#22 for the changes to the Python reference implementation). - Some changes are made to function names to reflect the shift from preparing ZSAs for V7 rather than V6. - There are changes to the tests to use the `zcash_unstable` flag in order to cover both ZSA and vanilla Orchard behavior. - The test vectors are also expanded to include both the V5 vectors, and the V7 vectors (behind a `zcash_unstable` flag).
PaulLaux
reviewed
Jul 25, 2024
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Good overall, added some comments about code duplication.
…h is inherited by OrchardActionDEscription and OrchardZSAActionDescription
…nd zip_0244_zsa files
PaulLaux
reviewed
Aug 11, 2024
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Good overall, some minor tweaks are required.
PaulLaux
reviewed
Aug 11, 2024
PaulLaux
reviewed
Aug 11, 2024
PaulLaux
previously approved these changes
Sep 4, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
PaulLaux
reviewed
Sep 18, 2024
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
added one comment to clarify intent.
PaulLaux
reviewed
Sep 18, 2024
PaulLaux
reviewed
Sep 18, 2024
PaulLaux
approved these changes
Sep 19, 2024
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
very nice.
Please make sure that this PR does not change the QED-it/orchard#114 vectors. Update if needed.
Author
|
Confirmed that QED-it/orchard#114 captures the changes made in this PR. |
vivek-arte
added a commit
to QED-it/orchard
that referenced
this pull request
Oct 8, 2024
This updates the test vectors in this repository to match those created in QED-it/zcash-test-vectors#22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes: