Closed
Conversation
PaulLaux
reviewed
Jun 29, 2023
|
This PR is outdated, and the material is subsumed into #22 -- which includes both burn and issue additions to the transaction ID and sighash generation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a change to the
transaction.pyscript in thezcash_test_vectorsrepository. The modification adds aburnvector to the serialized bundle, covering both empty and non-empty burn scenarios. This change is essential for generating appropriate test vectors for the updated version of thelibrustzcash/zcash_primitivescrate from theburn_read_write_validatebranch. On this branch, a "burn" field was added into serialization and deserialization functions for the bundle.Furthermore, in this pull request, I have refactored
orchard/asset_id.pyto add aderive_random_assetbase function and used it to generate asset bases for the burn items.Additionally, the Rust, JSON, and Zcash output files have been updated to reflect these changes.