forked from zcash/halo2
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[to upstream] Add a LookupRangeCheck trait and minor modifications in preparation for ZSA #32
Open
ConstanceBeguier
wants to merge
102
commits into
main
Choose a base branch
from
improve-backward-compatability-without-zsa
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[to upstream] Add a LookupRangeCheck trait and minor modifications in preparation for ZSA #32
ConstanceBeguier
wants to merge
102
commits into
main
from
improve-backward-compatability-without-zsa
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to create a Point from a constant. This functionality is required to evaluate the old nullifier. - for non split_notes, nf_old = Extract_P([PRF^{nfOrchard}_{nk}(rho_old) + psi_nf) mod q_P] NullifierK + cm_old) - for split notes, nf_old = Extract_P([PRF^{nfOrchard}_{nk}(rho_old) + psi_nf) mod q_P] NullifierK + cm_old + NullifierL)
Short range checks on 4 and 5 bits are now performed with only one lookup (instead of 2). To do that, we added a column `table_short_range_tag` in the lookup table. This new column `table_short_range_tag` contains the value - 4 for rows used in short range check on 4 bits - 5 for rows used in short range check on 5 bits - 0 for rows used in short range check on 10 bits Disable tests on i686 and code coverage in CI
It is now possible to perform a mux between two points or between two non-identity points. `mux(choice, left, right)` will return `left` when `choice=0` and `right` when `choice=1`. `choice` must be constrained to `{0, 1}` outside the gate. It is no longer needed to expose `from_coordinates_unchecked`.
…oint (#22) To share ZEC and ZSA hash computations in Orchard circuit's note commitment evaluation, we need to compute a Sinsemille hash from a private input point.
This reverts commit 23a2951.
…senting the circuit) is as expected
…om:QED-it/halo2 into improve-backward-compatability-without-zsa
…rcuit Previously, the functions test_against_stored_vk and test_against_stored_proof each generated a verification key (vk). This operation can be quite slow. We are combining these two tests to generate the vk only once.
PallasLookupRangeCheck <- PallasLookupRC PallasLookupRangeCheckConfig <- PallasLookupRCConfig
PaulLaux
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor comments and questions
PaulLaux
changed the title
Add a LookupRangeCheck trait and minor modifications in preparation for ZSA
[to upstream] Add a LookupRangeCheck trait and minor modifications in preparation for ZSA
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following modifications:
LookupRangeCheck
trait that provides common methods for a lookup range check.EccPointQ
enum to handle public and private points for Q, which is the initialization point for the hashing function.To adjust existing code to these modifications, developers will just need to import
halo2_gadgets::utilities::lookup_range_check::LookupRangeCheck
.This Orchard PR demonstrates how to adapt the Orchard code.
Upstream PR: zcash#823