Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiplexer chip #23

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Add multiplexer chip #23

merged 3 commits into from
Oct 17, 2023

Conversation

ConstanceBeguier
Copy link

@ConstanceBeguier ConstanceBeguier commented Oct 16, 2023

It is now possible to perform a mux between two points or between two non identity points.
mux(choice, left, right) will return left when choice=0 and right when choice=1.
choice must be constrained to {0, 1} outside the gate.

It is no longer needed to expose from_coordinates_unchecked

Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment

halo2_gadgets/src/utilities/mux.rs Show resolved Hide resolved
@ConstanceBeguier ConstanceBeguier merged commit 2392cc2 into zsa1 Oct 17, 2023
34 checks passed
ConstanceBeguier added a commit that referenced this pull request Oct 19, 2023
It is now possible to perform a mux between two points or between two non-identity points.
`mux(choice, left, right)` will return `left` when `choice=0` and `right` when `choice=1`.
`choice` must be constrained to `{0, 1}` outside the gate.

It is no longer needed to expose `from_coordinates_unchecked`.
ConstanceBeguier added a commit that referenced this pull request Nov 23, 2023
It is now possible to perform a mux between two points or between two non-identity points.
`mux(choice, left, right)` will return `left` when `choice=0` and `right` when `choice=1`.
`choice` must be constrained to `{0, 1}` outside the gate.

It is no longer needed to expose `from_coordinates_unchecked`.
ConstanceBeguier added a commit that referenced this pull request Dec 7, 2023
It is now possible to perform a mux between two points or between two non-identity points.
`mux(choice, left, right)` will return `left` when `choice=0` and `right` when `choice=1`.
`choice` must be constrained to `{0, 1}` outside the gate.

It is no longer needed to expose `from_coordinates_unchecked`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants