Fix various build issues - #172, #173, #178 #182
Merged
+220
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's still not entirely clear what the underlying issue is, but the ALSA device provided by pulseaudio stops working after so many tests use it. I've tried various approaches, but simply restarting pulseaudio after every test is a bruteforce but successful solution. In practice it also doesn't have any noticeable performance penalty, so it seems like a file solution. The `CI_TESTING` environment variable is used to avoid restarting pulseaudio if the tests aren't being run in the CI environment (we don't want to restart your pulseaudio instance if you're running them locally!)
libz tests were missing, I added one to test the libz dependency. Additionally $CONSOLE:ONLY creates many weird interactions and is currently broken in some cases. This adds tests for all the dependencies that can work with $CONSOLE:ONLY to verify that they compile correctly.
The _DEVICES command pulls in some stuff that depends on `winmm`. Normally this isn't a problem, but if `$CONSOLE:ONLY` is used then this dependency can actually get removed from the `CXXLIBS` and cause linking to fail. It's easy enough to fix this by always adding `-lwinmm` if `_DEVICES` is in use. Fixes: QB64-Phoenix-Edition#178
A quick fix, but providing `DEPENDENCY_CONSOLE_ONLY` when compiling audio.cpp tells `common.h` to avoid pulling in `freeglut.h`, which fixes the linking issue. Fixes: QB64-Phoenix-Edition#172
These tests were intended to be added by QB64-Phoenix-Edition#171, but the Linux build was having problems. The issues with the build have since been resolved so the tests are getting added back in. Fixes: QB64-Phoenix-Edition#173
mkilgore
requested review from
a user,
SteveMcNeill,
a740g and
RhoSigma-QB64
a740g
approved these changes
Sep 17, 2022
RhoSigma-QB64
approved these changes
Sep 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a handful of related changes:
$CONSOLE:ONLYdependency combinations, since$CONSOLE:ONLYis a bit jank and these have been causing us pain lately.SOUNDtests do not work in CI, and add them back. #173-lwinmmif we're using_DEVICES.audio.cppshould not includelibqb.h, doing so breaks$Console:Only#172 by adding-DDEPENDENCY_CONSOLE_ONLYwhen building audio.o. This tellscommon.hto avoid includingfreeglut.h, which is what caused the error.Fixes: #172
Fixes: #173
Fixes: #178