Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine why new SOUND tests do not work in CI, and add them back. #173

Closed
mkilgore opened this issue Sep 11, 2022 · 0 comments · Fixed by #182
Closed

Determine why new SOUND tests do not work in CI, and add them back. #173

mkilgore opened this issue Sep 11, 2022 · 0 comments · Fixed by #182
Assignees
Labels
bug Something isn't working

Comments

@mkilgore
Copy link
Contributor

Tests for #171 were written and planned to be added, but unfortunately they do not pass in CI. Investigation needs to be done into why adding new sound-based tests causes issue on Linux.

I added the first sound-based testing in #164, and to get it working on Linux I had to install and start pulseaudio as a way to get a fake ALSA card in place. The Linux build agents do not have any ALSA sound cards by default, so trying to use any sound-related functionality produces an error - running pulseaudio to get a fake ALSA card in place fixes the issue. It seems likely that something isn't quite right with this approach though, because the new sound tests cause the other sound-based tests to again hit the issue of no sound card being on the system. Presumably pulseaudio stopped working, removed it's fake sound card, or something else to that effect.

I was able to recreate the issue in my fork so it seems very consistent (ignoring the failures in Windows/Mac, that branch doesn't have the changes from #171 that make the tests pass). That should make it reasonably easy to test things and determine the issue. Unfortunately the biggest issue is that I never found a better solution to getting an ALSA card in place beyond pulseaudio, so it might be hard to find an alternative if that's the problem.

@mkilgore mkilgore added the bug Something isn't working label Sep 11, 2022
@mkilgore mkilgore self-assigned this Sep 17, 2022
mkilgore added a commit to mkilgore/QB64pe that referenced this issue Sep 17, 2022
These tests were intended to be added by QB64-Phoenix-Edition#171, but the Linux build was
having problems. The issues with the build have since been resolved so
the tests are getting added back in.

Fixes: QB64-Phoenix-Edition#173
mkilgore added a commit to mkilgore/QB64pe that referenced this issue Sep 17, 2022
These tests were intended to be added by QB64-Phoenix-Edition#171, but the Linux build was
having problems. The issues with the build have since been resolved so
the tests are getting added back in.

Fixes: QB64-Phoenix-Edition#173
mkilgore added a commit that referenced this issue Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant