Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor qbs into separate source file(s) in libqb/ #146

Closed
mkilgore opened this issue Aug 28, 2022 · 0 comments · Fixed by #453
Closed

Refactor qbs into separate source file(s) in libqb/ #146

mkilgore opened this issue Aug 28, 2022 · 0 comments · Fixed by #453
Labels
libqb-refactor Separating out libqb.cpp

Comments

@mkilgore
Copy link
Contributor

The qbs functionality is the backing for the STRING type in QB64-PE. It's functionality in libqb.cpp is somewhat hairy, but it's mostly self-contained and a good candidate for moving out of libqb.cpp and into its own source file(s), along with a header for all the qbs structs and function definitions. Since it's used almost everywhere this will go a long way in allowing other parts of the code to be moved out.
@mkilgore mkilgore added the libqb-refactor Separating out libqb.cpp label Aug 28, 2022
@mkilgore mkilgore mentioned this issue Aug 28, 2022
Open
@mkilgore mkilgore mentioned this issue Sep 10, 2022
Closed
mkilgore added a commit to mkilgore/QB64pe that referenced this issue Feb 13, 2024
@mkilgore
Separate out qbs, command, and error handling
b6b0285 
Moves the qbs, command, and error handling APIs into separate .cpp files
in libqb/src/. This makes only minor changes to the actual code beyond
moving the logic, many global variables are left in place to be dealt
with in further changes.

Fixes: QB64-Phoenix-Edition#146
mkilgore added a commit to mkilgore/QB64pe that referenced this issue Feb 13, 2024
@mkilgore
Separate out qbs, command, and error handling
7e089cf 
Moves the qbs, command, and error handling APIs into separate .cpp files
in libqb/src/. This makes only minor changes to the actual code beyond
moving the logic, many global variables are left in place to be dealt
with in further changes.

Fixes: QB64-Phoenix-Edition#146
mkilgore added a commit to mkilgore/QB64pe that referenced this issue Feb 14, 2024
@mkilgore
Separate out qbs, command, and error handling
21a207e 
Moves the qbs, command, and error handling APIs into separate .cpp files
in libqb/src/. This makes only minor changes to the actual code beyond
moving the logic, many global variables are left in place to be dealt
with in further changes.

Fixes: QB64-Phoenix-Edition#146
mkilgore added a commit to mkilgore/QB64pe that referenced this issue Feb 14, 2024
@mkilgore
Separate out qbs, command, and error handling
29efa96 
Moves the qbs, command, and error handling APIs into separate .cpp files
in libqb/src/. This makes only minor changes to the actual code beyond
moving the logic, many global variables are left in place to be dealt
with in further changes.

Fixes: QB64-Phoenix-Edition#146
mkilgore added a commit to mkilgore/QB64pe that referenced this issue Feb 14, 2024
@mkilgore
Separate out qbs, command, and error handling
4f4181f 
Moves the qbs, command, and error handling APIs into separate .cpp files
in libqb/src/. This makes only minor changes to the actual code beyond
moving the logic, many global variables are left in place to be dealt
with in further changes.

Fixes: QB64-Phoenix-Edition#146
@mkilgore mkilgore mentioned this issue Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libqb-refactor Separating out libqb.cpp
Projects
Backlog/In Progress
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libqb refactor - Part 1 mkilgore/QB64pe
1 participant
@mkilgore