Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor simple func_s and sub_s into libqb/ #149

Open
mkilgore opened this issue Aug 28, 2022 · 0 comments
Open

Refactor simple func_s and sub_s into libqb/ #149

mkilgore opened this issue Aug 28, 2022 · 0 comments
Labels
libqb-refactor Separating out libqb.cpp

Comments

@mkilgore
Copy link
Contributor

libqb.cpp contains the definitions for most of the func_ and sub_ C++ functions which are called from the QB64-PE code. While lots of these hook into many of the various internal parts of libqb.cpp, others are fairly stand alone and either have no real dependencies, or only depend on things like qbs and the GFS API (#146, #148). These are things like many of the math functions, stuff like sub_chdir(), some file support functions, etc.

It would be good to get the ball rolling and start pulling these out into new source files somewhere in libqb/ (maybe libqb/src/subfuncs or something), we should be able to reduce the size of libqb.cpp somewhat, get the libqb/ layout more defined, and make it easier to see what the harder parts of libqb.cpp might be.

This also includes cleaning up some pulled in via other files, such as func__loadimage() as noted in #141. Those probably shouldn't be pulled into the libqb/ folder but instead kept in source files under internal/c/parts/. They will likely need some additional build logic for conditional compiling.

@mkilgore mkilgore added the libqb-refactor Separating out libqb.cpp label Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libqb-refactor Separating out libqb.cpp
Projects
None yet
Development

No branches or pull requests

1 participant