Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TrainerProperties Mixin and move property definitions directly into trainer.py #9495

Merged
merged 12 commits into from
Sep 18, 2021

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Sep 13, 2021

What does this PR do?

Fixes #8946

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@daniellepintz daniellepintz changed the title deprecate trainerproperties mixin and move properties to trainer.py Deprecate TrainerProperties Mixin and move property definitions directly into trainer.py Sep 13, 2021
@mergify mergify bot removed the has conflicts label Sep 13, 2021
tests/trainer/test_trainer.py Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #9495 (e1417c8) into master (86c0335) will decrease coverage by 5%.
The diff coverage is 94%.

❗ Current head e1417c8 differs from pull request most recent head 238eb1c. Consider uploading reports for the commit 238eb1c to get more accurate results

@@           Coverage Diff           @@
##           master   #9495    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         180     180            
  Lines       15090   15469   +379     
=======================================
- Hits        14019   13604   -415     
- Misses       1071    1865   +794     

@ananthsub ananthsub added this to the v1.5 milestone Sep 15, 2021
@mergify mergify bot removed the has conflicts label Sep 15, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Adrian Wälchli <[email protected]>
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify mergify bot added ready PRs ready to be merged has conflicts labels Sep 16, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan, but I guess it is the first step toward something better.

@mergify mergify bot removed the has conflicts label Sep 18, 2021
@tchaton tchaton enabled auto-merge (squash) September 18, 2021 09:32
@tchaton tchaton merged commit 290398f into Lightning-AI:master Sep 18, 2021
@daniellepintz
Copy link
Contributor Author

SeanNaren pushed a commit that referenced this pull request Sep 22, 2021
…tly into `trainer.py` (#9495)

Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
@daniellepintz daniellepintz mentioned this pull request Sep 30, 2021
12 tasks
@daniellepintz daniellepintz deleted the mixin branch March 12, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate TrainerProperties Mixin and move property definitions directly into trainer.py
5 participants