-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate TrainerProperties Mixin and move property definitions directly into trainer.py
#9495
Conversation
trainer.py
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #9495 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 180 180
Lines 15090 15469 +379
=======================================
- Hits 14019 13604 -415
- Misses 1071 1865 +794 |
Co-authored-by: Adrian Wälchli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daniellepintz !
We should do the same thing for this mixin too: https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/trainer/deprecated_api.py
This can be in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge fan, but I guess it is the first step toward something better.
…tly into `trainer.py` (#9495) Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: thomas chaton <[email protected]>
What does this PR do?
Fixes #8946
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃